search

AesopInteractive / lasso

Code Repository for Editus (formerly Lasso) Commercial Plugin
https://edituswp.com
GNU General Public License v2.0
147 stars 25 forks source link

WP API V2 nag from Lasso #93

Open michaelbeil opened 9 years ago

michaelbeil commented 9 years ago

On the latest GitHub version of WP API (v2), Lasso doesn't save the dismissed state when prompted to install WP API via TGMPA.

This should be resolved as we up the WP API version that we are using.

bearded-avenger commented 9 years ago

There's quite a few things that we're going to have to change when V2 is released I think.

michaelbeil commented 9 years ago

Definitely.

Shelob9 commented 9 years ago

@michaelbeil You misunderstood me. This happens when I checkout from Github, no matter which branch I am on. I suspect this is because it checks out with a different file path.

bearded-avenger commented 9 years ago

^

yep i think wp-json is hardcoded like a tard that i am

bearded-avenger commented 9 years ago

isn't v2 like v2 or something?

michaelbeil commented 9 years ago

oh, golly.

robmcclel commented 9 years ago

@michaelbeil and @bearded-avenger I think this is the bug I recently experienced with Survivors. I downloaded the update direct from GitHub, but it didn't sync with the API.

The timeline was that I downloaded and installed Lasso 0.9.6 to get the latest correction for author posts. I installed it and activated, thinking I had already installed REST. When I activated Lasso, it prompted me to install REST and I smacked my forehead for being a rube. However, after I installed REST, it didn't sync.

It will allow me to create posts and access them from the front end -- just not edit them in any way.

bearded-avenger commented 9 years ago

@robmcclel this is referencing the beta release of V2 of the WP REST API, which hasn't been released yet. Current version is 1.2.2.

bearded-avenger commented 9 years ago

also, the REST API not being activated has nothing to do with saving and editing a post. the only thing it's used for is to show the posts and pages on the front-end. If you're not able to edit the post then the setting for the article class likely isn't correct.

robmcclel commented 9 years ago

Then it sounds like it's not finding the right container to edit -- that was an issue a few iterations ago. I'm sure when single install in multi-site is supported, it will resolve itself.

On Sat, Jun 27, 2015 at 8:28 AM, Nick Haskins notifications@github.com wrote:

also, the REST API not being activated has nothing to do with saving and editing a post. the only thing it's used for is to show the posts and pages on the front-end.

— Reply to this email directly or view it on GitHub https://github.com/AesopInteractive/lasso/issues/93#issuecomment-116089326 .

bearded-avenger commented 9 years ago

Lasso is used on Story.AM, which is multisite, and works as it was designed if all subsites have the same theme and markup. As you are aware, the multisite rewrite to use per site options is time consuming, and we have an open issue about it #76 and #77 . It involves rewriting the option screen, the options handler, the localized variables, the license screen, and license update system.

robmcclel commented 9 years ago

Oh, I know. You guys are doing great -- it's no easy task. Keep doing what you're doing. It'll work out.

On Sat, Jun 27, 2015 at 8:45 AM, Nick Haskins notifications@github.com wrote:

Lasso is used on Story.AM, which is multisite, and works as it was designed if all subsites have the same theme and markup. As you are aware, the multisite rewrite to use per site options is time consuming, and we have an open issue about it #76 https://github.com/AesopInteractive/lasso/issues/76 and #77 https://github.com/AesopInteractive/lasso/issues/77 . It involves rewriting the option screen, the options handler, the localized variables, the license screen, and license update system.

— Reply to this email directly or view it on GitHub https://github.com/AesopInteractive/lasso/issues/93#issuecomment-116090191 .