Aetf / kwin-maxmize-to-new-desktop

KWin script that moves fullscreened window to a new virtual desktop
BSD 2-Clause "Simplified" License
55 stars 20 forks source link

Virtual desktop is not removed on window close #14

Closed rjazhenka1 closed 2 years ago

rjazhenka1 commented 2 years ago

The title says it all.

I've poked around the source code to find the cause of the issue and found out that client becomes undefined after windowClosed signal is sent, causing errors.

code:

closed: function(client) {
    log('handle remove');
    log(client);
    ...
}

output:

js: KWinMax2NewVirtualDesktop: handle remove
js: KWinMax2NewVirtualDesktop: undefined
...
file:///home/ildar/.local/share/plasma-interactiveconsole/interactiveconsoleautosave.js:81: TypeError: Cannot read property 'windowId' of undefined

Maybe the script was broken by a KDE update?

I can provide more information about my system if needed.

Aetf commented 2 years ago

Thanks for the report and investigation. I just noticed the same issue. I'll look into this shortly.

Aetf commented 2 years ago

Looks like an upstream KWin bug, I just reported it: https://bugs.kde.org/show_bug.cgi?id=449181

For now, I implemented a workaround it in ae55754

PH7-Jack commented 2 years ago

I have the same issue

Aetf commented 2 years ago

@PH7-Jack commenting on a closed issue can hardly have your problem solved. Especially this one is specifically about an upstream bug that has been worked around.

Please open a new issues with more information if the problem persists. Thanks.