Aether-Tools / CustomizePlus

Dalamud plugin designed to give you better control over your Final Fantasy XIV character appearance.
Apache License 2.0
21 stars 10 forks source link

Added IPC to request profile list and apply profile by GUID #1

Closed Limiana closed 8 months ago

Limiana commented 8 months ago

Hello! Readded IPC methods from previous version in different fashion.

RisaDev commented 8 months ago

Hello, thank you for your PR. I assume this is PR for DynamicBridge support. Unfortunately right now it cannot be accepted without some overhaul because using temporary profiles system to switch between profiles of a local player is incorrect.

Here is what needs to be done:

If you want this IPC to support setting profiles to arbitrary characters please let me know and I'll think of best approach.

AsunaTsuki commented 8 months ago

Sorry, yes this is for DynamicBridge. Ty so much for the feedback! We will get back to you with changes :)

Limiana commented 8 months ago

If you want this IPC to support setting profiles to arbitrary characters please let me know and I'll think of best approach.

I had a feature request to add a possibility to apply random profiles to all other characters so that'd be nice

RisaDev commented 8 months ago

I had a feature request to add a possibility to apply random profiles to all other characters so that'd be nice

After taking quick look I see that it seems like DynamicBridge only operates on the local player, so I propose we leave this idea for some point in the future because after thinking about it I came to conclusion that proper implementation involves changing quite a bunch of stuff and there is a lot of other stuff which has bigger priority.

It will probably involve temporary profiles, but that means that temporary profiles need to accomodate quite a bunch of additional game state changes like moving between the zones and UI needs to be modified to allow user to see and control temporary profiles. Basically quite a bunch of work which needs to be thoroughly thought out in order to work properly both for Mare and other plugins.

Limiana commented 8 months ago

That's totally fine, applying profiles to other players would be lower priority task for me either. I will edit this PR to match the requirements later today

Limiana commented 8 months ago

All the changes are finished now, I also added extra method to disable profile by ID since revert character method is only used with temporary profiles

RisaDev commented 8 months ago

Thank you, here is the plan - I want to use this opportunity to establish some base infrastructure for new IPC, so I will merge this into a separate branch and do some refactoring and changes. I will probably slightly alter some methods you added, so I ask you to not rely on this IPC for now. By the time next version is released this IPC will be ready to be used.

Limiana commented 8 months ago

Okay, that sounds good!