AetherModel / Aether

This is the home of the Aether model of the thermosphere and ionosphere
GNU General Public License v3.0
19 stars 29 forks source link

Adding vertical neutral-neutral friction #118

Closed robfleur closed 1 year ago

robfleur commented 1 year ago

Description

Addresses #80

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

I added output (with verbose level 4) that prints each coefficient from the vector.

Test configuration

Checklist:

aburrell commented 1 year ago

@roober-t can you rename this pull request to reflect the changes instead of calling it "develop"? Perhaps something like "Adding vertical neutral-neutral friction"?

robfleur commented 1 year ago

Since the initial pull request, I have added a newline to the bottom of ion_neutral_collision_frequencies. I also got rid of all extraneous comments throughout the code, including a few print statements in read_collision_file.cpp.

aaronjridley commented 1 year ago

@aburrell - can you do a quick check of this? I have cleaned it all up, made a test, and verified that everything works (found a major bug in the vertical gradient for non-uniform grids!). This should work well with the vertical advection pull request that is pending.

aaronjridley commented 1 year ago

Fixed some of the formatting changes that were suggested, merged the changes with the develop branch (removed report and input from the function calls), and fixed some bugs.