AetherStation / AetherStation13

LRP flavour of tgstation experience
GNU Affero General Public License v3.0
16 stars 33 forks source link

esword airlock slicing #330

Closed TheChosenEvilOne closed 1 year ago

TheChosenEvilOne commented 1 year ago

About The Pull Request

Allows slicing open airlocks with esword.

Why It's Good For The Game

https://www.youtube.com/watch?v=K48M2S7bkSA

Changelog

:cl: add: Added slicing airlocks open with energy swords. /:cl:

Helg2 commented 1 year ago

I think 10 seconds a little too fast, but the idea is cool

TheChosenEvilOne commented 1 year ago

I think 10 seconds a little too fast, but the idea is cool

That is on desword which has a force of 34, it takes nine hits from it to break an airlock. melee attack cooldown is 8 deciseconds, so it takes 7,2 seconds to break an airlock by just hitting it.

TheChosenEvilOne commented 1 year ago

now that I actually think about it, I should make it faster on both.

AndroidMK2 commented 1 year ago

Sounds cool, I'm all for this

Livrah commented 1 year ago

Does it have a sound durning do_after? Breaking an airlock by esword hits is loud af.

TheChosenEvilOne commented 1 year ago

Does it have a sound durning do_after? Breaking an airlock by esword hits is loud af.

there is a sound when you start it and a sound when it ends, there is no real way of making do_after play sounds.

github-actions[bot] commented 1 year ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself