Incompatability between In Dappled Groves, and Toolworks, on VS version 1.19.8

[vegvel31]

Tried porting my current singleplayer modded setup to VS version 1.19.8 from 1.19.7, and everything seemed to work until I encountered an issue between Toolworks and In Dappled Groves. The error seems to prevent me from booting up any save, new or old, but does not remove the save file. Only by having the mods enabled separate can I boot properly. I took an image of how it looks when trying to boot up with both mods enabled, in case this is of any interest. I have also added some program logs, that I thought might be relevant. Please let me know if you need other files as well.

My 1.19.7 save is still working, even after updating to the latest mod versions, so I'll be able to continue playing my modded world. Thought I'd let you know regardless for bugfixing purposes. Seems that the logs are pointing to Toolworks specifically: "Can't create itemstack without item!" (1) & "Object reference not set to an instance of an object." (2)

client-main.txt (1)

server-main.txt (2)

[VinterNacht]

Hmmmm... I'll check into this. The odd thing is that I developed the compact in 1.19.8, and I'm rather curious about this sudden incompatibility after upgrade. I doubt this will have any meaningful effect, but did you try doing a modconfig wipe after upgrading?

Oh, this one is going to be a strange one indeed. So when I first relaunched with both mods installed, I saw the bug. I tried removing both individually to confirm it wasn't either one of them alone. Then I installed them both again and ran it and the error didn't appear, and all installed mods seem to work without unknown issues.

In none of those cases did it crash on launch... This is going to be fun.

Also, strangely, this is the only report I've gotten about this error despite the ongoing requests for its compatibility.

[vegvel31]

The error was experienced on a clean save on a creative world, to test whether there was any bugs or errors etc before doing the bigger porting of my existing save. I thus don't think that there should be any config-related errors being ported over.

It only seems to be on the 1.19.8 version though, the 1.19.7 one works fine, despite using the same files.

Just let me know if you want any more of those debug or server files!

[vegvel31]

Added this on the VS mod page as well, but disabling Ancient Tools (Recent version, 1.5.18 ) seems to fix the issue, for some reason. Booted up both a creative and survival world to check, and so far, everything seems to work as normal.

Maybe something to do with the adzes and bark recipes, given that the mods have those in common?

[VinterNacht]

Doubftful, we've both been sure to maintain compatibility with the other. I think her adze recipes disable, as do the bark ones, when my mod is included.

[vegvel31]

Ok. Well, disabling the mod seems to make Toolworks and In dappled groves play nice with each other. Before I knew of this the mods (Toolworks and In Dappled groves) had to be disabled for the other to work, all while Ancient Tools probably was enabled in the background. I'll do some more testing tomorrow and see what combinations work and which doesn't.

[vegvel31]

So I did some further tests (Making a new creative world each time), removing all other mods to further isolate the trio in question, and it seems to only be the situation where all three are active at once, that triggers the bug. Every other combination works as normal. I even tried rolling back versions for both In dappled groves and Ancient tools, in case the bug was introduced recently, and it was only for In dappled groves versions between v0.4.3-rc.2 and v0.4.7 that seemed to work, which are older versions by this point.

Just in case I had misremembered, I also decided to test on my 1.19.7 game version by creating a new creative world, to check if the bug happened there as well. And sadly that seems to be the case, despite me initially believing otherwise.

The strange thing is that I have a save file where all three mods seems to function together without fail (The one I'm trying to transfer to 1.19.8), despite the error occurring when trying to make a new world. And that world had In Dappled Groves added after initial world generation. Without knowing for certain, maybe the issue happens during initial world gen somehow? But that does not seem to make a lot of sense either, since I tried activating Ancient tools on a test file that initially had it disabled (On 1.19.8), and it lead to the same crash as mentioned at the start of the thread.

Regardless, I'll try to transfer the save for 1.19.7 that works into 1.19.8, and see if it boots or encounters the same bug.

[vegvel31]

Update: The save works, no error or conflict between the three mods by transferring the save to 1.19.8. So the issue seems to be related to the initial generation of a new world.

Don't know how to further test this outside of comparing older version of mods 1 to 1. Just give me a holler if you want to check out the save that works, in case you can find out something from that.

[teagan75]

I am out right now but I was playing nicely with tool works and in dappled groves when i decided to add ancient tools and it crashed. I will upload logs when i get back. I am going to assume it’s on their end tho but not sure

[Pikabyte]

Hey, Just thought I should let you know, that this issue is on Toolworks' end. Basically, it happens because Toolworks has built-in special compatibility for Ancient Tools but not for In Dappled Groves. However, long after the last update of Toolworks, Ancient Tools added their own built-in compatibility for In Dappled Groves that disables the Adze from Ancient Tools. Unfortunately, Toolworks expects the adze from Ancient Tools to e Dxist, causing Exception: Can't create itemstack without item!

Removing the json patches that Toolworks does to Ancient Tools' Adze fixes the issue. So, I'm hoping to try to make a compatibility patch that just disables them when In Dappled Groves is present.