AetiasHax / ph

Decompilation of The Legend of Zelda: Phantom Hourglass
17 stars 2 forks source link

End functions after constant pools #46

Closed AetiasHax closed 6 months ago

AetiasHax commented 6 months ago

I've moved all arm_func_end and thumb_func_end assembly macros below the constant pools of their respective functions.

The primary reason for this is to improve compatibility with objdiff, which relies on the function symbol's size when it disassembles a function's code. We want to include pool constants in the disassembly, so the end macros had to be moved.

A positive side effect of this is that the xMAP now reports the correct size for assembly functions 👍