Aetopia / NoSteamWebHelper

A program that disables Steam's CEF/Chromium Embedded Framework.
GNU General Public License v3.0
123 stars 6 forks source link

Potential application of this project #18

Closed PikaMug closed 3 months ago

PikaMug commented 3 months ago

Hello Aetopia,

Could I implore you to look into whether NoSteamWebHelper could include a workaround for this issue? https://steamcommunity.com/discussions/forum/1/6725643788916599657/

Tl;dr: Recently, client version 1718305227 was pushed to the masses, and it appears to break Steam for anyone with multiple graphics options enabled. For example, if someone has both an AMD Radeon HD 7990 (primary) and Intel integrated graphics (secondary), they'd likely be affected. The exact symptoms are that Steam WebHelper crashes repeatedly, none of the client-suggested choices (like disabling GPU acceleration) work, and the problem cannot be remedied by any of the common solutions online.

The reason I ask is, setting -no-browser came up a lot and, after switching to integrated graphics, installing your project sped up my client considerably. Would it be out of scope for it to also undo whatever change was made to the web helper to bring this about?

This post from a separate thread is particularly relevant: https://steamcommunity.com/discussions/forum/1/4333106230734794460/?ctp=2#c4343239957176490349

Aetopia commented 3 months ago

The reason why this issue gets fixed is due to the arguments NoSteamWebHelper launches Steam with:

NoSteamWebHelper uses these arguments to restrict the WebHelper to a single process for easier process termination when enabling and disabling it.

This option seems to effectively solve this issue you mentioned.

For some or the other reason using GPU WebViews with NoSteamWebHelper would causes Steam crash on startup (You can't start Steam unless the WebHelper is running.).

PikaMug commented 3 months ago

Thanks for your reply. Unfortunately, -cef-disable-gpu-compositing does not solve it.

I should have better explained that NoSteamWebHelper does not currently fix the issue, but rather once the only known workaround is applied (disabling the primary graphics option) your project is helpful in speeding up WebHelper on the secondary (slow integrated graphics in my example).

Since it's known that the recent update is causing WebHelper to crash, I was wondering if you might try including a fix for this in NoSteamWebHelper, if you feel it's adjacent.

Aetopia commented 3 months ago

I see. What about trying to select what GPU, the WebHelper runs on?

If it doesn't run on the problematic GPU then there should be no problems.

PikaMug commented 3 months ago

I see. What about trying to select what GPU, the WebHelper runs on?

If it doesn't run on the problematic GPU then there should be no problems.

Is that possible for an end user? Seems like a good solution, but I can't find anything about it online.

Aetopia commented 3 months ago

You can. https://www.intel.com/content/www/us/en/support/articles/000090168/graphics.html

PikaMug commented 3 months ago

Ah, thought you meant via Steam. The summary in that link says "or integrated graphics" but the initial instructions are only for dedicated graphics cards (there is no "Discrete Graphics Card" populated) and I tried just the final steps below, but Options doesn't give me the integrated graphics as a choice. I'll keep trying and follow up.

Aetopia commented 3 months ago

Would you mind sending a screenshot of your GPU options?

PikaMug commented 3 months ago

Kind of you to assist (:

gfx

Apparently, the 'Power saving' choice is usually the iGPU, but not always.

Aetopia commented 3 months ago

Is this older hardware by any chance? If it that is the case then reporting the issue to Valve is the only best choice or downgrading Steam.

PikaMug commented 3 months ago

It is older, but yes I agree that's the ideal solution. If you're not super interested in adding a workaround to NoSteamWebHelper that's understandable, but I appreciate you taking a look. Hopefully Valve comes through as it seems to affect newer hardware, as well.

Aetopia commented 3 months ago

Closing this issue.