search

Aeva / m.grl

Midnight Graphics & Recreation Library
http://mgrl.midnightsisters.org
GNU Lesser General Public License v3.0
44 stars 3 forks source link

Setup symlink structure so that only one copy of gl-matrix needs to be shipped. #233

Closed mldulaney closed 8 years ago

mldulaney commented 8 years ago

This will make both distro packaging and upgrading gl-matrix easier. gl-matrix now just lives in libs and everything else is symlinked to that.

Signed-off-by: John Dulaney jdulaney@fedoraproject.org

Aeva commented 8 years ago

So, as we mentioned in conversation elsewhere, I'm not willing to merge anything that breaks compatibility with Windows. Unfortunately, git converts symlinks into text files that contain only the path of where the file was meant to point to. As that breaks any local development on Windows, I can't merge this PR as-is.

An alternative approach would be to serve a singular copy of gl-matrix in the root of the repository (or in a libs folder like you have it), and then change all of the index.html files to point to that instead. I generally assume in the repository that if it is being served, the repository root directory is where the files are being served from, and therefor "/gl-matrix.js" would probably be the best URI to use. Relative paths might also be fine, but it would be more of a bother to make sure they're all correct.