search

Afforess / Factorio-Stdlib

Factorio Standard Library Project
ISC License
162 stars 45 forks source link

busted test fails, lua 5.3 doesn't have `unpack` #126

Closed sparr closed 6 years ago

sparr commented 6 years ago

I'm running lua 5.3 so I get a single failure from make test:

Error → spec/area/area_spec.lua @ 172
Area should validate area spiral iteration
./stdlib/area/area.lua:412: attempt to call a nil value (global 'unpack')

My naive attempt at a fix was to add a line to spec/setup/world.lua:

if not _G.unpack then _G.unpack = table.unpack end

This had no apparent effect. That's as far as I got.

Afforess commented 6 years ago

Factorio uses Lua 5.21, and so does stdlib. 5.3 is unsupported.

Nexela commented 6 years ago

Partially re opened. unpack is deprecated in 5.2. I will switch stuff to table.unpack

On Thu, Apr 5, 2018, 10:36 AM Cameron McAvoy notifications@github.com wrote:

Factorio uses Lia 5.21, and so does stdlib. Sorry, 5.3 is unsupported.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Afforess/Factorio-Stdlib/issues/126#issuecomment-378958213, or mute the thread https://github.com/notifications/unsubscribe-auth/ANUy4MAMGsUt3NLHokSQulLdagh2-lQDks5tlivNgaJpZM4TH89j .