Afforess / Factorio-Stdlib

Factorio Standard Library Project
ISC License
162 stars 45 forks source link

Event.register not passing pattern to function #157

Closed DeadlyKitten37 closed 2 years ago

DeadlyKitten37 commented 2 years ago

Describe the Bug

When using Event.register in http://afforess.github.io/Factorio-Stdlib/modules/Event.Event.html

I tried to use a pattern with out a filter. Event.register(defines.events.on_entity_died, onSomethingDestroyed, nil, "died") Event.register(defines.events.on_player_mined_entity, onSomethingDestroyed, nil , "mined") Event.register(defines.events.on_robot_mined_entity, onSomethingDestroyed, nil , "mined")

I expected it to pass the pattern to onSomethingDestroyed without trying to filter it, instead it passed nil to the 2nd argument of onSomethingDestroyed

Nexela commented 2 years ago

It looks like I should be able to change this allow passing the pattern to the event when the filter isn't used.