AfikDeri / v-credit-card

Beautiful credit card form component for vueJS
MIT License
62 stars 27 forks source link

Card number and expiration validation #6

Closed rtician closed 4 years ago

rtician commented 4 years ago

Hello,

I'm using Firefox and valid card numbers and expirations are being alert as wrong: image

I think it's because the attribute pattern="[0-9]*" on the input. Chrome doesn't seem to have a problem with it.

ci83rtda commented 4 years ago

I created a pull request to fix the issue

7

gtbustos commented 4 years ago

It seems this wasn't updated on latest version. Could you check it out? <input type="text" name="card_number" pattern="[0-9]*" inputmode="numeric">

Best!

AfikDeri commented 4 years ago

@gtbustos it looks like it's in the latest version, are you sure you don't see it?

gtbustos commented 4 years ago

"v-credit-card": "^1.2.1",

image

The source code on Github is ok, I can't see it on npm package. I rebuilt the package and it works fine but I rather use the official version.

rtician commented 4 years ago

Hi @AfikDeri, any updates?

AfikDeri commented 4 years ago

Sorry for the delay, it should work now, try version 1.2.2