Afischbacher / Nhl.Api

The Official Unofficial .NET NHL API
MIT License
25 stars 3 forks source link

v3.4.1 #54

Closed Afischbacher closed 4 months ago

Afischbacher commented 4 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

[!WARNING]

Rate Limit Exceeded

@Afischbacher has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 44 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between da9a01df06c4e5d7de7c79f8759b897d2e1fb70b and 7bfab26de8f92d24792bd5faa1358288a979b0a5.

Walkthrough

The recent update introduces a new .editorconfig file for unified code standards and refines various components across the project for clarity and efficiency. Changes include syntax simplifications, namespace and import adjustments, and enhancements in error handling and HTTP client configurations. Additionally, model and service layers saw improvements in readability and functionality, alongside test enhancements for better coverage. The version bump to 3.4.1 reflects these meticulous refinements aimed at bolstering the project's robustness and maintainability.

Changes

Files Change Summary
.editorconfig, Nhl.Api/.editorconfig Introduced comprehensive configuration settings for consistent coding styles and conventions.
Nhl.Api.Common/Exceptions/* Reordered namespaces and import statements in exception classes.
Nhl.Api.Common/Extensions/* Corrected namespaces, refactored methods, and reordered statements in extension files.
Nhl.Api.Common/Helpers/* Enhanced readability in helper methods and reordered namespace and imports.
Nhl.Api.Common/Http/* Fixed syntax errors and reordered namespaces across HTTP client files.
Nhl.Api.Common/Services/* Simplified syntax using expression-bodied members in service classes.
Nhl.Api.Domain/Enumerations/* Moved namespace declarations to the top and adjusted using directives in enumeration files.
Nhl.Api.Domain/Models/* Reordered namespaces, fixed syntax errors, and enhanced models across various files.
Nhl.Api.Domain/Services/NhlTeamService.cs Refactored switch statements to use expression-bodied members for improved code structure.
Nhl.Api.Tests/* Enhanced tests with new assertions, refactored methods, and reordered namespaces and imports.
Nhl.Api/Src/* Refactored method declarations to use expression-bodied members and updated return statements in API classes.

Poem

🎉🐰

In the realm of code where the ice is slick,
A rabbit hopped in, with a stick so quick.
It tweaked and tuned, with a careful eye,
Making the code sing, under the digital sky.
"To version 3.4.1, we leap with glee,
For cleaner code, as far as the eye can see."
🎉🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 96.14396% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 89.31%. Comparing base (7195c33) to head (7bfab26). Report is 9 commits behind head on master.

Files Patch % Lines
Nhl.Api.Domain/Services/NhlTeamService.cs 91.83% 7 Missing and 5 partials :warning:
Nhl.Api/Src/Api/NhlApi.cs 91.42% 4 Missing and 2 partials :warning:
Nhl.Api.Common/Helpers/TimeStampHelper.cs 66.66% 0 Missing and 2 partials :warning:
Nhl.Api.Common/Services/CachingService.cs 66.66% 1 Missing and 1 partial :warning:
Nhl.Api/Src/LeagueApi/NhlLeagueApi.cs 86.66% 0 Missing and 2 partials :warning:
Nhl.Api.Common/Extensions/EnumExtensions.cs 0.00% 0 Missing and 1 partial :warning:
Nhl.Api.Common/Helpers/CountryCodeHelper.cs 99.79% 0 Missing and 1 partial :warning:
Nhl.Api.Common/Services/NhlApiAsyncHelper.cs 50.00% 1 Missing :warning:
...ain/Models/Player/ExpressionGoalieFilterBuilder.cs 66.66% 1 Missing :warning:
...ain/Models/Player/ExpressionPlayerFilterBuilder.cs 66.66% 1 Missing :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #54 +/- ## ========================================== + Coverage 88.70% 89.31% +0.61% ========================================== Files 75 75 Lines 3276 3435 +159 Branches 438 438 ========================================== + Hits 2906 3068 +162 + Misses 303 300 -3 Partials 67 67 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.