search

AfonsoTsukamoto / ATTutorialController

A tutorial controller ready to use. Uses its own UIWindow.
MIT License
83 stars 10 forks source link

Label for Tutorial Swipe Misaligned on iPhone 6 and Tutorial Label gets cut off after exceeding certain number of lines and characters. #1

Open VentureNguyen opened 9 years ago

VentureNguyen commented 9 years ago

Hi,

I noticed two bugs when using this pod.

  1. The Label for Tutorial Swipe was aligned to the center using a hard coded value for the width. On iPhone 6, since the device width is larger than previous versions of the iPhone, the label is no longer center aligned. I found the issue and changed the hard coded value to use the device's window width. Will submit a pull request for this.

  2. In using the tutorial label, if I exceed a certain number of lines or characters, the label get's cut off with a "..." Setting the label's number of lines to 0 appears to fix this issue. This will be part of the same pull request.

    This property controls the maximum number of lines to use in order to fit the label’s text into its bounding rectangle. The default value for this property is 1. To remove any maximum limit, and use as many lines as needed, set the value of this property to 0.

VentureNguyen commented 9 years ago

Pull request to fix the two issues above: https://github.com/AfonsoTsukamoto/ATTutorialController/pull/2

VentureNguyen commented 9 years ago

This is my first pull request as well. Let me know if you need additional information or screenshots for the bugs above. The fixes are working well for me in iPhone 6 sized device.

VentureNguyen commented 9 years ago

Hi @AfonsoTsukamoto , just wondering if you will be pulling these bug fixes in. Thanks!