Closed ghost closed 9 years ago
You could have made it dynamic (i.e. remove -r from the string and parse the two integers) but hey this is a good start. Welcome to the code. Permission to merge? @Afr0Games/owners
Looks OK on a glance. I'm trusting you on this one, LetsRace. Merge!
I can't make code comments because I'm blocked from your repository apparently? I'll just post them all here.
The old implementation that inferred the resolution from the string seemed like a more eloquent and flexible solution, why not fix that up?
//
/// <summary>
/// Converts and outputs a string array into a proper
/// string using the Join method.
/// </summary>
/// <remarks>http://www.dotnetperls.com/convert-string-array-string</remarks>
/// <param name="array"></param>
static string ConvertStringArrayToStringJoin(string[] array)
{
//
// Use string Join to concatenate the string elements.
//
string result = string.Join("", array);
return result;
}
Why did you implement a function for a one liner? Considering string.Join("", array); is pretty self explanatory anyways, this is a waste of space.
I was tired. I'll get rid of it.
Not the summary, the existence of the function in the first place.
Oh. It was the only way I could make it work without getting errors.
string userRes = string.Join("", args);
????
Hey, it worked. xD Anyway, phasing that out for the old implementation. Will commit it in a sec.
My implementation has been removed in favour of the older, more dynamic, one. Feel free to merge.
Looks good from my perspective.
Merged.
Thank you.
You got code from me. Thanks to @LetsRaceBwoi for helping me figure out this one last compiler error I faced.