AfriCC / php-epp2

A High Level EPP TCP/SSL Client for PHP
GNU General Public License v3.0
53 stars 32 forks source link

Alternatives to intl translisterate #3

Closed jbarbede closed 9 years ago

jbarbede commented 9 years ago

When I tried to use intl transliterator_transliterate function, I got a segmentation fault (probably related to my OS and PHP version) but I didn't get time to investigate why it ocurred. I preferred to switch to derick transliterate function (http://derickrethans.nl/projects.html#translit).

It could be great to get alternatives to translit, including a really basic one that doesn't require a PHP extension and make it configurable.

lifeofguenter commented 9 years ago

Hi @jbarbede - that is a extension as well, and is deprecated: https://pecl.php.net/package/translit

There is unfortunately no other solution, as using something like iconv is not threadsafe. What OS and PHP version were you using?

jbarbede commented 9 years ago

I installed intl on Centos 6 with PHP 5.5. At least Derick function works on this configuration.

Maybe you can just offer a basic function to translit, something similar to this gist https://gist.github.com/sgmurphy/3098978 if intl transliterate is not installed.

People requiring full and clean transliteration then should install intl.

lifeofguenter commented 9 years ago

That gist is messed up and will do more harm than good - I'd rather fallback to iconv but then output a warning each time "using deprecated function" or similar

jbarbede commented 9 years ago

ok, it sounds great like that.

Julien Barbedette

On Tue, Apr 21, 2015 at 4:17 PM, Günter Grodotzki notifications@github.com wrote:

That gist is messed up and will do more harm than good - I'd rather fallback to iconv but then output a warning each time "using deprecated function" or similar

— Reply to this email directly or view it on GitHub https://github.com/AfriCC/php-epp2/issues/3#issuecomment-94945678.

lifeofguenter commented 9 years ago

Sorry, but I checked again the comments on: http://za1.php.net/manual/en/function.iconv.php - and the behaviour is just too unpredictable. So I won't replace anything - but this library is anyway "open source" so feel free to modify for your needs :)

Apart from that, with the newest changes (as you do not need type=int) you will also not need this function (it will not be called).

jbarbede commented 9 years ago

I am going to test all your changes asap. I also added some MX extension to support rar:info and domain:restore commands, your library is just perfect to work with EPP :-D.

Julien Barbedette

On Tue, Apr 21, 2015 at 6:20 PM, Günter Grodotzki notifications@github.com wrote:

Sorry, but I checked again the comments on: http://za1.php.net/manual/en/function.iconv.php - and the behaviour is just too unpredictable. So I won't replace anything - but this library is anyway "open source" so feel free to modify for your needs :)

Apart from that, with the newest changes (as you do not need type=int) you will also not need this function (it will not be called).

— Reply to this email directly or view it on GitHub https://github.com/AfriCC/php-epp2/issues/3#issuecomment-94970820.

lifeofguenter commented 9 years ago

Thanks, I'm glad to hear my library could help you out.

Also feel free to do a pull request with your changes. You will find an example in the "extension" folder where I added some stuff for COZA.