search

AfriCC / php-epp2

A High Level EPP TCP/SSL Client for PHP
GNU General Public License v3.0
53 stars 32 forks source link

Another fine present for 1.0.0 - HTTPClient #64

Closed johnny-bit closed 5 years ago

johnny-bit commented 5 years ago

Hi!

Some fine folks asked for one, but somehow I never got a round tuit to polish my HTTPClient. Now I have.

I know changeset reads like bad poetry and there are no tests (yet), but trust me - this is fine. I've been running that on production for a bit now :)

johnny-bit commented 5 years ago

Can we somehow get styleci & scruntizer code style, so that one could configure IDE autoformatting to avoid hitting styleci BS? Also - it seems that styleci & scruntizer aren't compatible enough ;)

lifeofguenter commented 5 years ago

awesome stuff again @johnny-bit - I can fully agree with this PR as its not changing the principle of xml based input/output but just adding a different client layer! Love it :)

ignore scrutinizer + codecov for now, the whole client.php needs some refactoring.. 👍

johnny-bit commented 5 years ago

ignore scrutinizer + codecov for now, the whole client.php needs some refactoring

Heh. doingit :D

johnny-bit commented 5 years ago

OK, this should be ready to merge.