search

AfriCC / php-epp2

A High Level EPP TCP/SSL Client for PHP
GNU General Public License v3.0
54 stars 31 forks source link

Guzzle #77

Closed bessone closed 4 years ago

bessone commented 4 years ago

Guzzle is required in the composer file (v. 3 now deprecated) but Guzzle is never used, even the HTTPClient uses Curl directly.

Am I missing something or can it be removed?

johnny-bit commented 4 years ago

0.o

Weird - it shouldn't require Guzzle.

can you submit a PR?

czw., 3 paź 2019 o 15:52 Riccardo Bessone notifications@github.com napisał(a):

Guzzle is required in the composer file (v. 3 now deprecated) but Guzzle is never used, even the HTTPClient uses Curl directly.

Am I missing something or can it be removed?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/AfriCC/php-epp2/issues/77?email_source=notifications&email_token=ACRRKFKYLKPAGSPYM2A7KVDQMX2LDA5CNFSM4I5DNH42YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HPNEW7A, or mute the thread https://github.com/notifications/unsubscribe-auth/ACRRKFIJXCPA3GIP5I3CP3DQMX2LDANCNFSM4I5DNH4Q .

-- Pozdrawiam, Hubert Kowalski

bessone commented 4 years ago

Sure, give me time to change the code. between tonight and tomorrow

bessone commented 4 years ago

Ok, just found the mistery!

Guzzle and some Symfony packages are required by satooshi/php-coveralls. The old 1.0 is required in composer.json, but also the last 2.8 has been abandoned by the maintainer who recommends php-coveralls/php-coveralls

I have to admit my ignorance and I don't know what it is for

johnny-bit commented 4 years ago

It's a connector for one of CI tools used, and that should only be dev req.

czw., 3 paź 2019 o 16:51 Riccardo Bessone notifications@github.com napisał(a):

Ok, just found the mistery!

Guzzle and some Symfony packages are required by satooshi/php-coveralls. The old 1.0 is required in composer.json, but also the last 2.8 has been abandoned by the maintainer who recommends php-coveralls/php-coveralls

I have to admit my ignorance and I don't know what it is for

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/AfriCC/php-epp2/issues/77?email_source=notifications&email_token=ACRRKFMWEUC6UA77ZFRTD6LQMYBFLA5CNFSM4I5DNH42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAIOYVA#issuecomment-537979988, or mute the thread https://github.com/notifications/unsubscribe-auth/ACRRKFNRCJZJVQWWLQ4YOBDQMYBFLANCNFSM4I5DNH4Q .

-- Pozdrawiam, Hubert Kowalski