AfriCC / php-epp2

A High Level EPP TCP/SSL Client for PHP
GNU General Public License v3.0
53 stars 32 forks source link

Add dependency injection for all objects relying on ObjectSpec #82

Closed johnny-bit closed 5 years ago

johnny-bit commented 5 years ago
lifeofguenter commented 5 years ago

Amazing work! So the reason get + sendFrame were public, is to allow people to do low-level stuff as there is no good/existing interface to do so currently?

As long as it will still be possible? Obviously cleaner to not have them public, but only if we either support all calls, or have an easy way to inject a custom handler? Not sure?

johnny-bit commented 5 years ago

I wondered about that... Usually one should implement get/sendFrame as a low-level stuff and let request to handle that. The only thing that would technically fail with this approach is long-running stuff where response frame is disassociated with request frame (eg very theoretical EPP-over-SMTP :stuck_out_tongue_closed_eyes:)

What usecases do you see for them being public? Obviously haing them public because no other class publishes them might also be good idea, so I can add that back, no problem :)

johnny-bit commented 5 years ago

Amazing work! So the reason get + sendFrame were public, is to allow people to do low-level stuff as there is no good/existing interface to do so currently?

As long as it will still be possible? Obviously cleaner to not have them public, but only if we either support all calls, or have an easy way to inject a custom handler? Not sure?

made them public again :) and done some refactoring, more testing etc :) Should be ready for mainlining.