AfricaHackTrip / simple-speed

Fast and simple Internet bandwidth speed testing
https://simplespeed.5apps.com
16 stars 7 forks source link

The 'Start test' button should click and not disappear #18

Closed lukehefson closed 10 years ago

lukehefson commented 10 years ago

Can we add an on-click a:active state to the 'Start test' button and stop it from disappearing during the test?

lukehefson commented 10 years ago

More on my logic:

'Start test' is definitely a button and I don't think that a button should ever disappear. Obviously it shouldn't be left enabled if it's going to break the test itself, so I can imagine a couple of solutions:

  1. Hitting the start test button again cancels the current test and starts a new test. This would be my ideal solution but I can appreciate that it may be hard to implement.
  2. The button gets disabled after being clicked and then re-enabled once the test has finished. We'd need to come up with a nice disabled state for the button, perhaps with the text in the button changing to Test in progress…?

What do you think @skddc?

raucao commented 10 years ago

Yes, I'd like to implement option 2. I agree that it makes more sense than just hiding it. We can still look into cancelling tests later and change the button behavior then.

lukehefson commented 10 years ago

Great. I'll work on a state for it.

lukehefson commented 10 years ago

Here's some mocks for those states.

Clicked state:

screen shot 2013-10-25 at 14 23 06

Disabled state:

screen shot 2013-10-25 at 14 23 19

raucao commented 10 years ago

I like it.

raucao commented 10 years ago

Done.