search

AfricaHackTrip / simple-speed

Fast and simple Internet bandwidth speed testing
https://simplespeed.5apps.com
16 stars 7 forks source link

Tweak new style #21

Closed lukehefson closed 10 years ago

lukehefson commented 10 years ago

Lots of little tweaks to the new design as it looks as though some of my changes broke when the design was updated.

raucao commented 10 years ago

I implemented the new CSS without merging, because you didn't account for small screens, so it was easier for me to incorporate your design ideas from scratch instead of merging and fixing.

Actually, I like it much better with more whitespace and smaller font sizes. Don't you?

I'd definitely tweak the number panels a little more according to your design, but I personally would like to keep the rest as it is. Anyone else has any opinions on this?

lukehefson commented 10 years ago

you didn't account for small screens, so it was easier for me to incorporate your design ideas from scratch instead of merging and fixing.

Ah, my bad. I was unsure how to do the CSS for small screens. Thanks for picking through it and fixing!

My intention with the reduced container width and bigger font sizes was to make the padding around the type consistently weighted so that the app appears to be more of a 'card' than a 'site'. But we should totally discuss the pros/cons of this!

I definitely think that 'kb/s' should be lowercase Helvetica rather than Palatino either way.

raucao commented 10 years ago

Changed the numbers as per your suggestion. Like it much better as well.

lukehefson commented 10 years ago

Closing as there's no reason to keep this PR open :smile:

raucao commented 10 years ago

:)