search

AfricaHackTrip / simple-speed

Fast and simple Internet bandwidth speed testing
https://simplespeed.5apps.com
16 stars 7 forks source link

Check Network State #22

Closed arky closed 11 years ago

arky commented 11 years ago

When the user taps [Start Test] check if the network state if offline or online.

Tested on FIrefox Android Nightly on Samsung S2 CM10.3

raucao commented 11 years ago

... and don't start the test if detected as offline? Maybe show a warning?

arky commented 11 years ago

Show a warning would be ideal.

raucao commented 11 years ago

Ok, will implement this using navigator.onLine. Thanks!

arky commented 11 years ago

Awesome Thanks @skddc!

raucao commented 11 years ago

Ok, unfortunately we can't do this yet, due to browser support not being good enough. It works on Chrome and Safari for me (OS X), but Firefox just keeps stating it's online, even when I disable the wi-fi.

There's a bug report already: https://bugzilla.mozilla.org/show_bug.cgi?id=783516

I added myself to the CC list. Please also vote for it!

arky commented 11 years ago

That's interesting @skddc

The navigator.online demo runs properly on my Mozilla Firefox nightly (nightly.mozilla.org) as expected. http://html5-demos.appspot.com/static/navigator.onLine.html

What the bug #783516 needs is a good test case.

raucao commented 11 years ago

Platform: All Mac OS X

;)

raucao commented 11 years ago

Oh crap, this is intended behaviour: https://bugzilla.mozilla.org/show_bug.cgi?id=620472

I disagree with the winning argument of the discussion, but apparently it's been had and the decision was made. I'll implement it after all then, because some Firefox for Mac users not seeing the message is not a show stopper.

raucao commented 11 years ago

Ok, done.

By the way, @arky, wanna rate the app?