search

AfshinLab / BLR

MIT License
5 stars 0 forks source link

Add DBS as library type and add depreciation warning for BLR #50

Closed pontushojer closed 3 years ago

FrickTobias commented 3 years ago

Since it's not released yet I'd just remove blr, if there isn't a particular reason why you'd want an in between version. To me it solves one issue by creating another one (with little benefit from what I can see right now).

Otherwise it looks good!

pontushojer commented 3 years ago

Since it's not released yet I'd just remove blr, if there isn't a particular reason why you'd want an in between version. To me it solves one issue by creating another one (with little benefit from what I can see right now).

The reason was backwards compatibility as we currently have a lot of runs with library_type=blr. For each of these we would need to change the configs to run this version of the pipe. Therefore it seemed nice to still allow 'blr' but use 'dbs' in new runs. Later on 'blr' would be removed.