feat(ui): text area focus and hover states

AfterClass-io / afterclass.io-v2

[alpha] v2 of https://afterclass.io!

https://afterclass-io.vercel.app

MIT License

4 stars 2 forks source link

feat(ui): text area focus and hover states #109

Closed k3ithloh closed 1 month ago

k3ithloh commented 3 months ago

closes #91

changes

updated <Textarea.theme/> component adding focus and hover states
updated <Textarea.stories/> component adding the Defaultsmall variant
update component page with Textarea component for testing

implementation

utilized existing focus-ring class for the base text area focus-visible state and added the additional required tailwind css
added a variant for the sm text area

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
afterclass-io-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 19, 2024 0:46am

Aztriltus commented 3 months ago

thanks for the PR! couple of questions otherwise, LGTM

@Aztriltus, was your intention also to add this focus-ring + hover behavior to the other components like button (or similar clickables)?

Yea we could

davidlhw commented 2 months ago

seems like there's a bug on the focus ring

light mode

dark mode

could we also add focus-ring to <Checkbox/>?

k3ithloh commented 2 months ago

Will look into the bugs you mentioned

k3ithloh commented 1 month ago

As clarified at the meeting the last time, the bug was introduced by shifting the CSS into the focus ring class which is only used in text area and not button