Closed davidlhw closed 3 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
afterclass-io-v2 | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 6, 2024 11:28am |
thanks for the PR @davidlhw, posted some minor thoughts/questions mobile view is not exactly working (not sure if thats the focus of this PR) other than those, tested locally (theme toggle, loading skeleton and layout for desktop) looks good
thanks for the review & comments @jeromeandrewong!
mobile view is not exactly working (not sure if thats the focus of this PR)
mobile view is indeed not the focus of this pr (and will not be for the first release either). Our user data simply doesnt justify the time / effort investment to perfecting the mobile view from the get-go
closes #90
changes
new
<PlusIcon/>
,<MoonIcon/>
,<SunIcon/>
,<EditIcon/>
<ReviewItemSkeleton/>
'/'
url path resolvable without authupdates
<Button/>
withasChild
prop to render only children instead of icons + children wrapped with span parentlogin
link button<ReviewItem/>
not showing proper body when locked<ReviewModal/>
to be client component instead of reliance on parent client components<ReviewSection/>
component instead and make parent page a server componenttesting
preview
https://github.com/AfterClass-io/afterclass.io-v2/assets/13061926/c7c24ce6-f8ef-4c3e-a4ff-54c39e9e5ea8