AfterClass-io / afterclass.io-v2

[alpha] v2 of https://afterclass.io!
https://afterclass-io.vercel.app
MIT License
4 stars 2 forks source link

feat(ui): review home page integration #111

Closed davidlhw closed 3 months ago

davidlhw commented 3 months ago

closes #90

changes

new

updates

testing

preview

https://github.com/AfterClass-io/afterclass.io-v2/assets/13061926/c7c24ce6-f8ef-4c3e-a4ff-54c39e9e5ea8

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
afterclass-io-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 11:28am
jeromeandrewong commented 3 months ago

thanks for the PR @davidlhw, posted some minor thoughts/questions mobile view is not exactly working (not sure if thats the focus of this PR) other than those, tested locally (theme toggle, loading skeleton and layout for desktop) looks good

davidlhw commented 3 months ago

thanks for the review & comments @jeromeandrewong!

mobile view is not exactly working (not sure if thats the focus of this PR)

mobile view is indeed not the focus of this pr (and will not be for the first release either). Our user data simply doesnt justify the time / effort investment to perfecting the mobile view from the get-go