search

AfterClass-io / afterclass.io-v2

[alpha] v2 of https://afterclass.io!
https://afterclass-io.vercel.app
MIT License
5 stars 2 forks source link

chore: hide search result item statistics on unauthenticated client #192

Closed davidlhw closed 1 month ago

davidlhw commented 2 months ago

~blocked by #191, to be reviewed after #191 merges~

Context

Following up to the changes introduced in #191, the count procedure is public and will allow anyone with knowledge of the endpiont to query for count of all reviews, which is undesirable

This PR makes count a private trpc procedure and removes review count and prof/course count on search results (previously relying on public procedure to display)

Changes

How to Test

  1. head to site and don't authenticate
  2. do search
  3. no longer see stats on search results

Preview / Screenshots

before after
image image

Checklist

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
afterclass-io-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 3:38pm