fix: prevent review modal close button autofocus

AfterClass-io / afterclass.io-v2

[alpha] v2 of https://afterclass.io!

https://afterclass-io.vercel.app

MIT License

5 stars 2 forks source link

fix: prevent review modal close button autofocus #196

Closed davidlhw closed 1 month ago

davidlhw commented 1 month ago

closes #169

Changes

Add preventDefault to onOpenAutoFocus to <Modal.Content/> component

Preview / Screenshots

How to Test

head to /
open a review item modal
no longer see close button autofocusing

Checklist

[x] I have read the CONTRIBUTING document
[x] I have tested the changes

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
afterclass-io-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 21, 2024 5:33am

Jaylin0312 commented 1 month ago

Notes

Note that radix-ui maintainer specifically mentioned that "typically one wouldn't want to completely prevent focus inside the dialog otherwise one will be breaking accessibility"

But in our case the team really does not see a need with having the autofocus on the close button, so we will disable it for now