update call to action buttons

AfterClass-io / afterclass.io-v2

[alpha] v2 of https://afterclass.io!

https://afterclass-io.vercel.app

MIT License

5 stars 2 forks source link

update call to action buttons #200

Closed davidlhw closed 2 weeks ago

davidlhw commented 1 month ago

Mockups / Screenshots

Current

To-be

Required Changes

github icon to OSS call to action button
update edit icon color on write a review call to action button

AlvinLingg commented 3 weeks ago

Are we going to have the variant determine the type of icons that appear in the CTA component? Or do we make it such that we pass in the icon types we want (left and right icons as props)?

for example: tertiary = github icon, secondary/unspecified = plus icon, in future some other variant = some default icon?

davidlhw commented 3 weeks ago

passing in icons as props seem to be better for decoupling