search

AfterShip / aftership-sdk-php

The PHP SDK of AfterShip API
65 stars 46 forks source link

Couriers::get() not compatibile with Request::GET() #17

Closed ghost closed 8 years ago

ghost commented 8 years ago

Dear Aftershipers,

In your SDK i get the following ERROR:

[Symfony\Component\Debug\Exception\ContextErrorException]
Runtime Notice: Declaration of AfterShip\Couriers::get() should be compatible with AfterShip\Core\Request::GET($url, $headers, $body)

The error is solved when i add parameters in the extended courier class to get function: public function get($url = null, $headers = null, $body = null)...

If i run your testing.php everything works fine. This is produced by symfony CLI. Are you gonna commit this? I don't know what else to do.

Thanks,

ghost commented 8 years ago

Maybe it is best to change the name in the Request.php file from GET to HTTP_GET or something...

sunnychow commented 8 years ago

Thanks @xeandrej comments on this. We will handle it. Thanks.

sunnychow commented 8 years ago

we merge the code. it's fixed