Put common code into a separate file for workflow_docker.py and workflow_scif.py - Githubissues

AgPipeline / issues-and-projects

Repository for issues and projects

BSD 3-Clause "New" or "Revised" License

3 stars 1 forks source link

Put common code into a separate file for workflow_docker.py and workflow_scif.py #551

Open Chris-Schnaufer opened 3 years ago

Chris-Schnaufer commented 3 years ago

Task to do See title

Reason Pylint is finding much similar code (a known problem) and fails the GitHub action. Currently have work-around to get past the error

Result Pylint is successful without having special exceptions for workflow_docker.py and workflow_scif.py

Steps to take

Move common code to new file (use lambda functions where it makes sense)
Update the Action YAML file to remove special pylint exceptions: https://github.com/AgPipeline/Atlana/blob/fe9209ff257616e3f0b1e38050891f17ef408f21/.github/workflows/testing_checks.yaml#L47 and https://github.com/AgPipeline/Atlana/blob/fe9209ff257616e3f0b1e38050891f17ef408f21/.github/workflows/testing_checks.yaml#L82-L83