search

Agalin / pidgin_macos_integration

Pidgin plugin adding macOS shell integration
BSD 2-Clause "Simplified" License
8 stars 2 forks source link

Menu entry "Settings" is missing #9

Open kgraefe opened 5 years ago

kgraefe commented 5 years ago

When the buddy list is in focus, none of the menus in the menu bar have the "Settings" entry. Normally this would be under "Extras". I noticed that it is under "Pidgin" when I focus a chat window, though.

Agalin commented 5 years ago

It's actually the last created window (or first after buddy list, not sure atm) - if you haven't open any conversations yet, you'll find settings available for buddy list (in "Pidgin" menu). Currently plugin is just reattaching a single reference, will need to copy it or handle menus differently altogether - it's not the only issue, help menu is behaving strangely too, not even going to talk about times when you disable and reenable plugin. And settings in "Pidgin" menu is the expected behavior - that's where native apps always place it. "About Pidgin" behaves in the exact same way (including movement to different windows).

kgraefe commented 5 years ago

I see. If it helps, you could disable unloading at runtime by returing FALSE in plugin_unload(). Pidgin will then just not load it at the next start.

You may need to listen to the core-quitting signal in order to clean up when the plugin is unloaded due to Pidgin shutting down.