AgentOps-AI / agentops

Python SDK for agent monitoring, LLM cost tracking, benchmarking, and more. Integrates with most LLMs and agent frameworks like CrewAI, Langchain, and Autogen

https://agentops.ai

MIT License

1.77k stars 170 forks source link

[Feature] Comply codebase with mypy and add test coverage #153

Closed the-praxs closed 5 months ago

the-praxs commented 5 months ago

📥 Pull Request

📘 Description This is still a WIP and the list will be updated regularly

Fixed mypy errors and docstring for Client class in client.py

🔄 Related Issue (if applicable)

14

🎯 Goal To make the codebase better by adding type checks and adding coverage in tests

🔍 Additional Context None at the moment

🧪 Testing Describe the tests you performed to validate your changes.

Thank you for your contribution to Agentops!

the-praxs commented 5 months ago

2 errors that remain from mypy check -

X | Y syntax for unions requires Python 3.10 - Backwards compatibility will require changing the codebase to use the Union type instead of the | operator
Cannot find implementation or library stub for module named "<module>" - Occurs for the langchain, openai, and tenacity libraries. This is not shown when the --ignore-missing-imports arg is used with mypy. A permanent solution would be to generate stub files for these libraries.

the-praxs commented 5 months ago

@areibman can you please approve the workflow for this PR?

areibman commented 5 months ago

@areibman can you please approve the workflow for this PR?

Thanks for doing this! Taking a look

bboynton97 commented 5 months ago

Is this in a state ready to review? :)

the-praxs commented 5 months ago

Is this in a state ready to review? :)

I will update some more over the weekend since I need to look at the new changes. Should be ready by Monday.

bboynton97 commented 5 months ago

@the-praxs just checking in on this! :)