Closed areibman closed 1 week ago
these are cool! do we want to add them to the README as well?
I'm not sure that we want to include these in this repo though. it adds 20MB to the repo size. we may be better off hosting in a bucket or having a separate repo for assets
I'm not sure that we want to include these in this repo though. it adds 20MB to the repo size. we may be better off hosting in a bucket or having a separate repo for assets
If they're going to be in docs anyway, I think it makes sense to just host it on Github which is free, has versioning, and is an effective CDN. I can't really name any other public docs sites that use external image hosting, and I also see a ton of repos with .mp4's in the readme
If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
If they're going to be in docs anyway, I think it makes sense to just host it on Github which is free, has versioning, and is an effective CDN. I can't really name any other public docs sites that use external image hosting, and I also see a ton of repos with .mp4's in the readme
We could look into using git LFS. I believe GitHub automatically offers a certain amount of blob storage to be used with LFS. Blobs/binary files still get an immutable and versioned pointer, but the file isn't stored in the repo, rather on a CDN
📥 Pull Request
📘 Description Updated screenshots, logos, and gifs. Will be used to update other notebooks across the web