curscascis
commented
3 years ago I've taken some time to review these changes, I apologize that it has been so long as I've been very busy. I have a couple issues but one main concern. Integration with magi bridge is out of the scope of what serious vote does. And so I cannot pull in this PR. What I can do is add an event whenever a vote is triggered in serious vote with all the information pertinent to the vote and the system. This could be implemented in V5. You are free to make a 3rd party utility that links both plugins. But the only interaction with SeriousVote would be hooking in to it's event listener, this way any other plugin author is able to listen to an event when it happens.
I wondered, why not make posts in deep about voting, moreover, was already a realization in the face of Magebridge, and left to do... but at one point I ran into a problem. It consists in the fact that when loaded I would like to verify the validity of the channel to send the message from config, if its absence or non-existence I had planned to take the canal from magebridge, but the trouble is, Magebridge cannot guarantee the willingness of the JDA, and hang the test would be weird. In the end, I came to a decision in the form of channel validation for each vote.. crutch. Also in the code, a large-scale refactoring was carried out using Intellij IDEA and my hands, the code was tested, not on all possible configurations, but did not encounter any problems I hope for your help