AgentSanchez / SeriousVote

Vote Listener For Sponge
3 stars 4 forks source link

{rewards} output seems to be inconsistent #44

Closed ZeotYT closed 2 years ago

ZeotYT commented 3 years ago

Just a quick report here regarding {rewards} variable output:

When using {rewards} in the default "broadcast-message:" config option, duplicate/double rewards are properly displayed individually, separated by a comma. Example:

Zeot voted and received 1x Gold Ingot, 1x Gold Ingot! (I receive 2 Gold Ingots)

When pulling the output of {rewards} into another method, duplicate/double rewards are not listed individually, and therefore the player never knows the double rewards were received. Example:

Zeot voted and received 1x Gold Ingot! (I receive 2 Gold Ingots)

AgentSanchez commented 2 years ago

So the only place that multiple selections of a reward exists is in the main rewards section. Milestones / Dailies do not allow for more than one reward to be selected from the random rewards and they each shoot out their own individual message. Nonetheless I have made it so all the broadcast calls will be the same and use the same rules to parse. I want to point out that the system has no knowledge of what you give out. To the system you are running commands and that is a completely independent component. You may include a quantity in the name of the reward such as Gold x 5. In the newer versions I was using sets to avoid listing individual components over and over again, as that can also be spammy, but I have switched it to lists. There is a possibility in the future of having it toggleable. Closed by 44072d7