AgentSanchez / SeriousVote

Vote Listener For Sponge
3 stars 4 forks source link

Add a sv-player-votes placeholder that parses the viewer #46

Closed zPr3d closed 3 years ago

zPr3d commented 3 years ago

Currently the placeholder sv-player-votes_{USERNAME} does not work in things like a virtual chest menu since you can't have the username placeholder within a placeholder.

Solution would be to just have sv-player-votes show the votes of the player that is interacting with the placeholder.

AgentSanchez commented 3 years ago

Hi unfortunately I cannot implement what you are asking as that is outside of the scope of what Serious Vote does or intends to do. The placeholder API support is provided as a means to facilitate other plugins that request SV data as a one way street and it provides that data as requested. I do know there are multiple communities successfully using these placeholders and they have been fine to date. If there is a plugin you are using who's interfacing cannot handle nested variables, or provide it's own variables unfortunately that is simply outside of the scope of what SV can offer. Attempting to add functionality for things like this would be skipping the middleman and touching API's that have nothing to do with the rest of the plugin.

There is a possible exception If it is possible for me to simply add parsing on my end to take an incoming placeholder and parse it, I can add that functionality, but It would have to be in the Serious Vote 5 release.

AgentSanchez commented 3 years ago

I've reviewed and believe I've added functionality for the placeholder to pass along an observer to the function. If I understand the documentation correctly, the functionality you requested will work next release. Closed by 8c4caeb