Agenta-AI / agenta

The all-in-one LLM developer platform: prompt management, evaluation, human feedback, and deployment all in one place.
http://www.agenta.ai
MIT License
1.23k stars 183 forks source link

Modify the column names within the aggrid and not outside in the testset view #333

Closed mmabrouk closed 1 year ago

mmabrouk commented 1 year ago

Is your feature request related to a problem? Please describe. Currently, if you want to change the column names in the test set view, you need to do it outside the table

Screenshot 2023-08-11 at 13 51 46

Describe the solution you'd like We would like to integrate the editing inside the table, basically you select the column names and you can change them, and then you have a + sign at the end of the header that you can use to add a column and another one to remove columns.

Additional context This is quite challenging to do. Only for the brave of you:)

witehound commented 1 year ago

@mmabrouk i am not sure what you mean you want to be able to add a new column completely or just edit and existing columns name?

mmabrouk commented 1 year ago

I mean:

witehound commented 1 year ago

You can assign this to me

mmabrouk commented 1 year ago

Done! Good luck! FYI @aakrem @MohammedMaaz

witehound commented 1 year ago

@MohammedMaaz how would removing of columns work if we do it outside the the table.

Screenshot 2023-08-11 at 17 40 32

I can work on the UI just want to be completely right with implementation.

witehound commented 1 year ago

@mmabrouk help needed.

mmabrouk commented 1 year ago

Hey @witehound, @MohammedMaaz told me he'd be unavailable this weekend. He will answer you tomorrow with the tech details.

mmabrouk commented 1 year ago

but not sure I understand your question, why would we need to remove the columns outside the table. The screenshot you give shows the delete button in the table header

witehound commented 1 year ago

I mean:

  • Add a new column by having a + sign at the end of the header
  • Rename the columns by editing their name
  • Removing columns by clicking on the bin in the header

@mmabrouk so I’m still working on the ui, as the core part was getting it to work, I think I misunderstood what header meant but it’s clearer now. Thank you.