search

Aghababaei / PhD-Seeker

Finding latest fully funded PhD positions for international students through web scraping
GNU General Public License v3.0
84 stars 11 forks source link

Source Retouch + CSV output #1

Closed javadr closed 2 years ago

javadr commented 2 years ago

Dear Amin,

First, I should appreciate your efforts to save the others' valuable time. I've made some retouching on your code to make it more concise. I've also added CSV output. IMHO, it would be better to sort the output based on their countries, resulting in putting similar items next to each other.

I believe that the Ph.D. seeker is more meaningful than Ph.D. finder. In addition phdseeker is shorter to be used in the command line than the original name you've chosen.

Best, Javad

Aghababaei commented 2 years ago

Dear Amin,

First, I should appreciate your efforts to save the others' valuable time. I've made some retouching on your code to make it more concise. I've also added CSV output. IMHO, it would be better to sort the output based on their countries, resulting in putting similar items next to each other.

I believe that the Ph.D. seeker is more meaningful than Ph.D. finder. In addition phdseeker is shorter to be used in the command line than the original name you've chosen.

Best, Javad

Dear Javad,

Thank you for taking the time to review the codes.

Your valuable modifications on sorting outputs, generating a CSV file, and retouching the code were reviewed accurately. Regarding naming, I agree with you. The name PhD-Seeker is easier to remember.

I hope it will be beneficial to everyone. I look forward to your further comments and pulls.

Regards, Amin