search

Aghababaei / PhD-Seeker

Finding latest fully funded PhD positions for international students through web scraping
GNU General Public License v3.0
84 stars 11 forks source link

Removing unnecessary files #11

Closed javadr closed 2 years ago

javadr commented 2 years ago

What do you think about removing the following files from the repo as they seem unnecessary?

PhD_Positions_2022-08-01.csv
PhD_Positions_2022-08-01.xlsx
Aghababaei commented 2 years ago

You are right Javad. It seems completely unnecessary. Watching potential results, however, could be motivating and helpful for newcomers and those who are not familiar with working with codes.

What about moving them to a sample_results folder? (although it seems unnecessary as well!)

javadr commented 2 years ago

Yep, it might be useful for someone to see the output in advance. Could you take a look at the following link and validate your theory about that? https://github.com/Aghababaei/PhD-Seeker/graphs/traffic

BTW, do what you think is better. I strongly suggest removing them from the root of the repository either by deleting them all or by moving under the other directory as you mentioned above.

Aghababaei commented 2 years ago

Just convinced! We can get rid of them!

The repository has seen 1269 viewers, among 2 percent of which care about the samples, meaning that hopefully, most phdseeker users are already familiar with how to work with codes (thanks to the comprehensive README).

javadr commented 2 years ago

Done!