search

AgileArchitect / MSBuild.SonarQube.Runner.Tool

MIT License
7 stars 12 forks source link

release of 4.3.1 introduced breaking change #13

Open quasarea opened 6 years ago

quasarea commented 6 years ago

We are using the SonarQube.Scanner.MSBuild.exe delivered in MSBuild.SonarQube.Runner.Tool to feed sonar with build results during jenkins builds.

at 4.3.0 the executable was located in fairly simple location: \tools\MSBuild.SonarQube.Runner.exe

you have changed the name of executable few times as I recall, but there was always deprecation done

at 4.3.1 the executable is located in \tools\sonar-scanner-msbuild-4.3.1.1372-net46\SonarQube.Scanner.MSBuild.exe

and I wonder what design it is? I understand you want to support two frameworks, but why then not just replicate system known in libs, i.e. tools\net46... ?

why to duplicate package name in package structure? why to add build version there? will you produce package with multiple build versions in it? or keep it changing with every release?

Sorry guys but this is madness

quasarea commented 6 years ago

image

WebDucer commented 6 years ago

This change also destroy also our build. The problem is very long subfolder names. We got from nuget the following error during restore of the sonarqube package:

Der angegebene Pfad und/oder Dateiname ist zu lang. Der vollständig qualifizierte Dateiname muss kürzer als 260 Zeichen und der Pfadname kürzer als 248 Zeichen sein.
NuGet exited with 1
An error occured while installing package MSBuild.SonarQube.Runner.Tool.
Error: Failed to install tool 'MSBuild.SonarQube.Runner.Tool'.

Why not use the standard framework moniker names (such as net46 and netcoreapp2.0)