search

AgileArchitect / MSBuild.SonarQube.Runner.Tool

MIT License
7 stars 12 forks source link

Updated Cake build and SonarQube runner files to v4.1.0.1148. #9

Closed burakince closed 6 years ago

burakince commented 6 years ago

https://github.com/SonarSource/sonar-scanner-msbuild/releases/tag/4.1.0.1148

It has 2 different runner now. (for .NET Framework 4.6 and .NET Core 2.0)

I updated runner looks like last time. But maybe this time we can make another runner directory for .NET Core 2.0 runner and we can extract 2 different nuget package. What you think @tomstaijen ?

B3nCr commented 6 years ago

Will this require changes to the Cake.Sonar runner to allow selection of the correct executable? I believe the msbuild version of the scanner is recommended for .NET Core and .NET framework so both scanners might not be necessary?

burakince commented 6 years ago

Hi @B3nCr

Will this require changes to the Cake.Sonar runner to allow selection of the correct executable?

I don't think so. It just execute the EXE in this line.

both scanners might not be necessary?

You absolutely right. We don't need 2 different runner in same time. That's why I send only .NET Framework 4.6 scanner on this pull request.

If you have .Net Framework or Mono on your system, you must use SonarQube .NET Framework 4.6 scanner. Otherwise (if you have .Net Core 2.0 on your system) you must use SonarQube .NET Core 2.0 scanner.

So, mostly it depends on what framework using on your system.

Thanks, Burak

B3nCr commented 6 years ago

It's a shame this doesn't publish a pre-release nuget package, It'd be good to see if this solves my problem.