search

AgileVentures / MetPlus_tracker

Git Repository for the Waffle issue in MetPlus project
2 stars 4 forks source link

Revisit JobSeeker model #284

Closed joaopapereira closed 8 years ago

joaopapereira commented 8 years ago

Rename function js_without_jd to something like find_without_job_developer Function your _jobseekers_jd maybe should be under AgencyPerson or renamed to something like find_by_job_developer

vijayakarumudi commented 8 years ago

Rename functions : js_without_jd => find_without_job_developer js_without_cm => find_without_case_manager

your_jobseekers_jd => find_by_job_developer your_jobseekers_cm => find_by_case_manager.

patmbolger commented 8 years ago

Suggest these substitutions:

JobSeeker.your_jobseekers_jd => JobSeeker.assigned_to_job_developer JobSeeker.your_jobseekers_cm =>JobSeeker.assigned_to_case_manager

vijayakarumudi commented 8 years ago

@Patrick what about js_without_jd and js_without_cm functions renaming suggestions

patmbolger commented 8 years ago

@vijayakarumudi - the original suggestions are OK. However, since "find" is generally used within RoR (I think) to return a single record, you could name these:

JobSeeker.js_without_jd => JobSeeker.without_job_developer JobSeeker.js_without_cm => JobSeeker.without_case_manager

joaopapereira commented 8 years ago

Replace your_jobseekers_jd your_jobseekers_cm

Instance methods of AgencyPerson: job_seekers_as_job_developer job_seekers_as_case_manager or job_developer_of case_manager_of

Up to you @vijayakarumudi

vijayakarumudi commented 8 years ago

@Team: I renamed instance methods in AgencyPerson: job_seekers_as_job_developer job_seekers_as_case_manager job_seekers_without_job_developer job_seekers_without_case_manager

patmbolger commented 8 years ago

I think those last two should be JobSeeker class methods, that is:

JobSeeker.job_seekers_without_job_developer JobSeeker.job_seekers_without_case_manager

We can discuss on today's stand-up.

vijayakarumudi commented 8 years ago

last two methods I moved into agency model.