AgileVentures / Paironauts

To find a pair partner any time!
MIT License
7 stars 5 forks source link

Added support for hound #25

Closed praveendhawan closed 4 years ago

praveendhawan commented 6 years ago

added support for hound

praveendhawan commented 6 years ago

@tansaku, @mattwr18 we might need to follow these steps for passing build on circle ci - https://dev.to/vinhnglx/integration-testing-phoenix-application-with-circle-ci-20-50md

tansaku commented 6 years ago

great work on this @praveendhawan and @mattwr18

probably some changes needed to CI - currently failing with:

  1) test when two users choose 'pair' from the homepage, they are added to a Jitsi (Paironauts.AcceptanceTest)
     test/browser/acceptance_test.exs:31
     ** (exit) exited in: GenServer.call(Hound.SessionServer, {:change_session, #PID<0.467.0>, :default, []}, 60000)
         ** (EXIT) an exception was raised:
             ** (RuntimeError) could not create a new session: econnrefused, check webdriver is running
                 (hound) lib/hound/session_server.ex:101: Hound.SessionServer.create_session/2
                 (hound) lib/hound/session_server.ex:78: Hound.SessionServer.handle_call/3
                 (stdlib) gen_server.erl:636: :gen_server.try_handle_call/4
                 (stdlib) gen_server.erl:665: :gen_server.handle_msg/6
                 (stdlib) proc_lib.erl:247: :proc_lib.init_p_do_apply/3
tansaku commented 6 years ago

I get some of the same locally:

Generated paironauts app
You have configured application :wallaby in your configuration file,
but the application is not available.

This usually means one of:

  1. You have not added the application as a dependency in a mix.exs file.

  2. You are configuring an application that does not really exist.

Please ensure :wallaby exists or remove the configuration.

...

  1) test when a user chooses 'mob' from the homepage, they are added to a single shared Jitsi (Paironauts.AcceptanceTest)
     test/browser/acceptance_test.exs:20
     ** (exit) exited in: GenServer.call(Hound.SessionServer, {:change_session, #PID<0.852.0>, :default, []}, 60000)
         ** (EXIT) an exception was raised:
             ** (RuntimeError) could not create a new session: econnrefused, check webdriver is running
                 (hound) lib/hound/session_server.ex:101: Hound.SessionServer.create_session/2
                 (hound) lib/hound/session_server.ex:78: Hound.SessionServer.handle_call/3
                 (stdlib) gen_server.erl:636: :gen_server.try_handle_call/4
                 (stdlib) gen_server.erl:665: :gen_server.handle_msg/6
                 (stdlib) proc_lib.erl:247: :proc_lib.init_p_do_apply/3

I guess I need to have webdriver configured and running ...?

tansaku commented 6 years ago

btw, @praveendhawan, if you put the issue number at the start of the branch (e.g. 22_hound_setup) it makes it super-easy to tab complete off just the issue number - are you a big fan of putting it at the tail end of the branch name?

praveendhawan commented 6 years ago

@tansaku Yeah you will need to install Phantomjs on your local and start it as a service using phantomjs --wd which will start Phantomjs server. Then on another console, you can run mix test

About the branch naming, not a big fan, its just kind of became a habit to include the issue number at the tail.

praveendhawan commented 4 years ago

Probably Out of date code. So closing this one.