AgileVentures / osra

Sponsor orphans in Syria & ensure basic life & education requirements for Syrian children
MIT License
20 stars 39 forks source link

OSRA-389 OSRA-390 father_alive -> father_deceased #345

Closed NikitaAvvakumov closed 9 years ago

NikitaAvvakumov commented 9 years ago

https://osraav.atlassian.net/browse/OSRA-389 https://osraav.atlassian.net/browse/OSRA-390

Replace father_alive in the Orphan model with father_deceased to match OSRA spreadsheets.

razorcd commented 9 years ago

can you send me a copy of the production db? I would like to test this PR

NikitaAvvakumov commented 9 years ago

@razorcd PM sent on Slack

gmunumel commented 9 years ago

What is the plan B in case we get a problem in production?

NikitaAvvakumov commented 9 years ago

@gmunumel Roll back the commits, restore db from backup. Painful but doable.

gmunumel commented 9 years ago

I guess you are going to try to apply this change at midnight. Are we gonna have a little test in prod? Do you have access to test it?

NikitaAvvakumov commented 9 years ago

Yes, we have access to the production db, so we can make sure that all orphan records are still valid after the update. @razorcd ran this against a copy of the production db last night and everything looked fine. Let's be very confident in our code before merging, that way we won't have to keep our finger on the 'Alarm' button as we push to production :)

gmunumel commented 9 years ago

hahaha, yes. :D

razorcd commented 9 years ago

:shipit:

gmunumel commented 9 years ago

Ready to go :+1: