Osra-444 add export functionality to orphan model

AgileVentures / osra

Sponsor orphans in Syria & ensure basic life & education requirements for Syrian children

MIT License

20 stars 39 forks source link

Osra-444 add export functionality to orphan model #415

Closed Maroo-b closed 8 years ago

Maroo-b commented 8 years ago

https://osraav.atlassian.net/browse/OSRA-444

add export to csv functionality to orphans and sponsors

b264 commented 8 years ago

I'm not sure about that test failure... I don't know if hardcoding the country is the best fix. But I don't know what the best fix would be. This works, but I'm not sure if it's ideal to use in the test or not. This would seem to be an implementation detail of the CSV output, I think.

2.3.0 :001 > [YAML.parse('"foo"').first.value, YAML.parse('foo').first.value]== ['foo', 'foo']
 => true

@razorcd @motasem-salem any ideas?

b264 commented 8 years ago

:+1:

Maroo-b commented 8 years ago

@b264 thanks for the review that was really helpful.

b264 commented 8 years ago

:shipit: