AgileVentures / osra

Sponsor orphans in Syria & ensure basic life & education requirements for Syrian children
MIT License
20 stars 40 forks source link

Include active sponsor #419

Closed NikitaAvvakumov closed 7 years ago

NikitaAvvakumov commented 7 years ago

This PR breaks a number of unit tests, mostly controller & view. All are low-level tests that are very fragile as they are tied too closely to the implementation detail. Rather than fixing them, I am inclined to either improve them or to drop them entirely. Would prefer to handle that separately in order to deliver the feature to the client ASAP

NikitaAvvakumov commented 7 years ago

@b264 Fixed the tests in place.

Going forward, refactoring and/or removing many of these should be a priority to avoid ~doubling the workload for each change or new feature. Right now, I'm tempted to just rm -rf spec/controllers. Back in the day, we drank way too much textbook Kool-Aid and chased after complete coverage instead of thinking about the purpose of these tests

b264 commented 7 years ago

:-D

b264 commented 7 years ago

:shipit:

Maroo-b commented 7 years ago

+1