search

AgileVentures / osra

Sponsor orphans in Syria & ensure basic life & education requirements for Syrian children
MIT License
20 stars 39 forks source link

Update dependencies #446

Closed NikitaAvvakumov closed 7 years ago

NikitaAvvakumov commented 7 years ago
  1. Leaving Gemfile without any versions for now because intend to immediately upgrade Rails to 5.x & Ruby to 2.3/2.4. Then will add version locks.
  2. roo gem (spreadsheet parsing) raises deprecation warnings because of the way the roo-xls gem calls its code. roo-xls is no longer maintained. We can live with the warnings for now, but at some point these will turn into exceptions. Can either fork & fix roo-xls (there is already a PR with the fix in the repo) or perhaps client doesn't need to work with the old XLS format any longer.
  3. To test, use https://osra-nga.herokuapp.com/, admin@example.com, Password1. Note that all old orphan lists have been deleted from S3. The error you get when attempting to download them is caused by this, not new gem versions. For testing, "partner100" has one list uploaded today that you can download, or upload your own.
coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.001%) to 99.183% when pulling 39339e5d8941719787f736c5347b41aa8ec35ac1 on NikitaAvvakumov:update-dependencies into 893df993232ebb81c8c6d522e5fde8bbf33ed55c on AgileVentures:develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.001%) to 99.183% when pulling 01572abfd909076c5ba774e5a41dd8b6c1ff867f on NikitaAvvakumov:update-dependencies into 893df993232ebb81c8c6d522e5fde8bbf33ed55c on AgileVentures:develop.

NikitaAvvakumov commented 7 years ago

@Maroo-b All specs are currently passing. Going forward, I would target controller specs for (selective) removal first. All specs could use a refactoring to decouple them from the implementation, avoid testing the framework, and generally test meaningful things only. It's probably best to do this separately from any other task or feature, not least so that we don't develop a bad habit of deleting failing specs instead of trying to fix them 😆

Maroo-b commented 7 years ago

That's interesting, usually I don't like fixing view spec and I opt for deleting it, maybe I should reconsider this habit :thinking: