search

AgileVentures / projectscope

MVP dashboard for ProjectScope, using new gems architecture developed by AV folks
2 stars 14 forks source link

[RDY] adds phantomjs gem #3

Closed tansaku closed 8 years ago

tansaku commented 8 years ago

fixes #1

armandofox commented 8 years ago

Do we really have to lock the ruby version to 2.3.1? i already have 5 versions of ruby installed under rvm to support different projects that have the ruby version locked...

tansaku commented 8 years ago

@armandofox I'm not sure - but I was getting a complaint about it being set ">= 2.0.0" - according to the bundler documentation I was reading that syntax isn't supported for setting the ruby version, although I might be wrong.

I have the following rubies installed:

→ rvm list

rvm rubies

   ruby-1.9.3-p551 [ x86_64 ]
   ruby-2.1.1 [ x86_64 ]
   ruby-2.2.0 [ x86_64 ]
   ruby-2.2.2 [ x86_64 ]
 * ruby-2.3.0 [ x86_64 ]
=> ruby-2.3.1 [ x86_64 ]

# => - current
# =* - current && default
#  * - default

and just keep on installing whatever's needed ...

We can lock to an earlier version but it will tend to generate warnings and things - good to be on the latest secure version no?

tansaku commented 8 years ago

@armandofox this PR is ready to pull in if you want. If we can find a better ruby syntax for the gem to specify a range of ruby versions that's cool (I couldn't immediately) - or if you want to lock to another version ...?