Closed tansaku closed 8 years ago
there are no new files or changes being made. the VCR config looks basically correct:
require 'vcr'
VCR.configure do |c|
c.hook_into :webmock
c.cassette_library_dir = 'features/support/fixtures/cassettes'
c.ignore_localhost = true
c.default_cassette_options = {
:match_requests_on => [
:method,
VCR.request_matchers.uri_without_param(:imp, :prev_imp)
],
# record: :new_episodes # uncomment this line to add new HTTP requests
}
c.filter_sensitive_data("<GITHUB_ACCESS_TOKEN>") { ENV['GITHUB_ACCESS_TOKEN'] }
c.filter_sensitive_data("<SLACK_ACCESS_TOKEN>") { ENV['SLACK_ACCESS_TOKEN'] }
c.filter_sensitive_data("<PIVOTAL_TRACKER_API_TOKEN>") { ENV['PIVOTAL_TRACKER_API_TOKEN'] }
end
VCR.cucumber_tags do |t|
t.tag '@vcr', :use_scenario_name => true
end
hmm, I wonder if the rake task is running in a separate thread and not being sandboxed by VCR ...
so the funny thing is we are hitting the rake task in the other cucumber test, and that's stable and fine - hmmm
so the difference is that the view_metrics_with_secrets.feature
has a slack metric using a secret token ... added show me the page ... can't see anything suspicious - feature passes if I change the metric value to match ... hmmm, will do PR on that, but I've done that fix a couple of times already - feels like there's a dependency I'm missing ...
I wonder if there is something indeterministic inside the slack gem - but tests are all green on that gem ...
seen this a few times now with errors like:
which is making it look like we have some kind of leak in the VCR sandboxing