search

AgileVentures / projectscope

MVP dashboard for ProjectScope, using new gems architecture developed by AV folks
2 stars 14 forks source link

Feature/whitelist #59

Open ysiad opened 7 years ago

ysiad commented 7 years ago
  1. Add feature tests for white list functionality
  2. Change the privilege of whitelist users that all whitelist users are able to add users and delete users
  3. Change the whitelist to hold GitHub usernames instead of emails
junyu-w commented 7 years ago

@ysiad merge conflicts needs to be resolved

tansaku commented 7 years ago

I'll try to review this tomorrow - apologies for the delay

tansaku commented 7 years ago

apologies for delay - please see comments embedded

tansaku commented 7 years ago

thanks @ysiad - can you address codeclimate issues?

tansaku commented 7 years ago

thanks @ysiad - we still seem to have some failing tests and codeclimate issues - do you need help interpreting them?